OSDN Git Service

of/pci: Fix theoretical NULL dereference
authorRobin Murphy <robin.murphy@arm.com>
Wed, 15 Nov 2017 12:50:06 +0000 (12:50 +0000)
committerRob Herring <robh@kernel.org>
Thu, 16 Nov 2017 17:01:14 +0000 (11:01 -0600)
commitc545f637f81ebab88c257a243083a879af0b85b7
tree46e46454d7729e1326fb16130f468c96f58ac24b
parentaa25e446ce76c37bfd75ac06598c316af94e9a26
of/pci: Fix theoretical NULL dereference

In the (relatively mechanical) process of adapting the RID-mapping code
to put the resulting ID in an output argument rather than the funtion
return value, we ended up with the debug print using the argument
pointer rather than the local value, which potentially defeats the
earlier NULL check.

Fixes: 987068fcbdb7: "of/irq: Break out msi-map lookup (again)"
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/of/of_pci.c