OSDN Git Service

scsi: iscsi: Fix HW conn removal use after free
authorMike Christie <michael.christie@oracle.com>
Thu, 16 Jun 2022 22:27:33 +0000 (17:27 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 22 Jun 2022 01:14:53 +0000 (21:14 -0400)
commitc577ab7ba5f3bf9062db8a58b6e89d4fe370447e
tree237689dc1ba5552e34b75e8916db37e04c56da78
parentf54912b228a8df6c0133e31bc75628677bb8c6e5
scsi: iscsi: Fix HW conn removal use after free

If qla4xxx doesn't remove the connection before the session, the iSCSI
class tries to remove the connection for it. We were doing a
iscsi_put_conn() in the iter function which is not needed and will result
in a use after free because iscsi_remove_conn() will free the connection.

Link: https://lore.kernel.org/r/20220616222738.5722-2-michael.christie@oracle.com
Tested-by: Nilesh Javali <njavali@marvell.com>
Reviewed-by: Lee Duncan <lduncan@suse.com>
Reviewed-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_transport_iscsi.c