OSDN Git Service

gpio: adnp: Fix testing wrong value in adnp_gpio_direction_input
authorAxel Lin <axel.lin@ingics.com>
Mon, 11 Mar 2019 13:29:37 +0000 (21:29 +0800)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Fri, 22 Mar 2019 15:48:47 +0000 (16:48 +0100)
commitc5bc6e526d3f217ed2cc3681d256dc4a2af4cc2b
treecdb68a6c7101ce5df45e742da2edeb2b80923e73
parent7ecced0934e574b528a1ba6c237731e682216a74
gpio: adnp: Fix testing wrong value in adnp_gpio_direction_input

Current code test wrong value so it does not verify if the written
data is correctly read back. Fix it.
Also make it return -EPERM if read value does not match written bit,
just like it done for adnp_gpio_direction_output().

Fixes: 5e969a401a01 ("gpio: Add Avionic Design N-bit GPIO expander support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-adnp.c