OSDN Git Service

perf maps: Do not use an rbtree to sort by map name
authorArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 13 Nov 2019 19:16:25 +0000 (16:16 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 18 Nov 2019 14:19:51 +0000 (11:19 -0300)
commitc5c584d2dbb0883f1e6f61872964a4a3a35a2017
treecf3a48b0e222af28a0497e324ab41044b354af14
parentbcb8af5c46e452018de9b58db1fd0ffd94b5d96c
perf maps: Do not use an rbtree to sort by map name

This is only used for the kernel maps, shave 24 bytes out 'struct map'
and just traverse the existing per ip rbtree to look for maps by name,
use a front end cache to reuse the last search if its the same name.

After this 'struct map' is down to just two cachelines:

  $ pahole -C map ~/bin/perf
  struct map {
   union {
   struct rb_node rb_node __attribute__((__aligned__(8))); /*     0    24 */
   struct list_head node;                   /*     0    16 */
   } __attribute__((__aligned__(8)));                                               /*     0    24 */
   u64                        start;                /*    24     8 */
   u64                        end;                  /*    32     8 */
   _Bool                      erange_warned;        /*    40     1 */

   /* XXX 3 bytes hole, try to pack */

   u32                        priv;                 /*    44     4 */
   u32                        prot;                 /*    48     4 */
   u32                        flags;                /*    52     4 */
   u64                        pgoff;                /*    56     8 */
   /* --- cacheline 1 boundary (64 bytes) --- */
   u64                        reloc;                /*    64     8 */
   u32                        maj;                  /*    72     4 */
   u32                        min;                  /*    76     4 */
   u64                        ino;                  /*    80     8 */
   u64                        ino_generation;       /*    88     8 */
   u64                        (*map_ip)(struct map *, u64); /*    96     8 */
   u64                        (*unmap_ip)(struct map *, u64); /*   104     8 */
   struct dso *               dso;                  /*   112     8 */
   refcount_t                 refcnt;               /*   120     4 */

   /* size: 128, cachelines: 2, members: 17 */
   /* sum members: 121, holes: 1, sum holes: 3 */
   /* padding: 4 */
   /* forced alignments: 1 */
  } __attribute__((__aligned__(8)));
  $

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-bvr8fqfgzxtgnhnwt5sssx5g@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/map_groups.c
tools/perf/util/map.c
tools/perf/util/map.h
tools/perf/util/map_groups.h
tools/perf/util/symbol.c