OSDN Git Service

sched/wait: Fix add_wait_queue() behavioral change
authorOmar Sandoval <osandov@fb.com>
Wed, 6 Dec 2017 07:15:31 +0000 (23:15 -0800)
committerIngo Molnar <mingo@kernel.org>
Wed, 6 Dec 2017 18:30:34 +0000 (19:30 +0100)
commitc6b9d9a33029014446bd9ed84c1688f6d3d4eab9
treee7dc6b07c6d578708109f7de8b0ca2520876b2eb
parent328b4ed93b69a6f2083d52f31a240a09e5de386a
sched/wait: Fix add_wait_queue() behavioral change

The following cleanup commit:

  50816c48997a ("sched/wait: Standardize internal naming of wait-queue entries")

... unintentionally changed the behavior of add_wait_queue() from
inserting the wait entry at the head of the wait queue to the tail
of the wait queue.

Beyond a negative performance impact this change in behavior
theoretically also breaks wait queues which mix exclusive and
non-exclusive waiters, as non-exclusive waiters will not be
woken up if they are queued behind enough exclusive waiters.

Signed-off-by: Omar Sandoval <osandov@fb.com>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-team@fb.com
Fixes: ("sched/wait: Standardize internal naming of wait-queue entries")
Link: http://lkml.kernel.org/r/a16c8ccffd39bd08fdaa45a5192294c784b803a7.1512544324.git.osandov@fb.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/wait.c