OSDN Git Service

perf/x86/intel: Use ULL constant to prevent undefined shift behaviour
authorColin King <colin.king@canonical.com>
Wed, 11 Jan 2017 11:43:10 +0000 (11:43 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Jul 2017 12:40:24 +0000 (14:40 +0200)
commitc78b8de5c05c73ff451b7c5a085766b421920ccd
treebb28f055c04e2effe32a66f4a13fdcad74a10032
parent6130fac994818eb0fbc9dfc95056292e71fb3791
perf/x86/intel: Use ULL constant to prevent undefined shift behaviour

[ Upstream commit ad5013d5699d30ded0cdbbc68b93b2aa28222c6e ]

When x86_pmu.num_counters is 32 the shift of the integer constant 1 is
exceeding 32bit and therefor undefined behaviour.

Fix this by shifting 1ULL instead of 1.

Reported-by: CoverityScan CID#1192105 ("Bad bit shift operation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Link: http://lkml.kernel.org/r/20170111114310.17928-1-colin.king@canonical.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/x86/events/intel/core.c