OSDN Git Service

net: enetc: fix aggregate RMON counters not showing the ranges
authorVladimir Oltean <vladimir.oltean@nxp.com>
Tue, 21 Mar 2023 23:28:31 +0000 (01:28 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 23 Mar 2023 03:39:10 +0000 (20:39 -0700)
commitc79493c3ccf06a3aeb72017a96ca3dfd166bc16b
treedc599edf22032f8edfdd1366805bea4ed6bb767f
parentbb765a743377d46d8da8e7f7e5128022504741b9
net: enetc: fix aggregate RMON counters not showing the ranges

When running "ethtool -S eno0 --groups rmon" without an explicit "--src
emac|pmac" argument, the kernel will not report
rx-rmon-etherStatsPkts64to64Octets, rx-rmon-etherStatsPkts65to127Octets,
etc. This is because on ETHTOOL_MAC_STATS_SRC_AGGREGATE, we do not
populate the "ranges" argument.

ocelot_port_get_rmon_stats() does things differently and things work
there. I had forgotten to make sure that the code is structured the same
way in both drivers, so do that now.

Fixes: cf52bd238b75 ("net: enetc: add support for MAC Merge statistics counters")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230321232831.1200905-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/enetc/enetc_ethtool.c