OSDN Git Service

drivers/net/wan/x25_asy: Added needed_headroom and a skb->len check
authorXie He <xie.he.0141@gmail.com>
Sun, 9 Aug 2020 02:35:48 +0000 (19:35 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 11 Aug 2020 17:32:05 +0000 (10:32 -0700)
commitc79f428d6f14e754503fa7a3145d62039ccd05c9
tree7771509e899ef8b08b96552eb21db6d56fbb6a20
parentb06c19d9f827f6743122795570bfc0c72db482b0
drivers/net/wan/x25_asy: Added needed_headroom and a skb->len check

1. Added a skb->len check

This driver expects upper layers to include a pseudo header of 1 byte
when passing down a skb for transmission. This driver will read this
1-byte header. This patch added a skb->len check before reading the
header to make sure the header exists.

2. Added needed_headroom

When this driver transmits data,
  first this driver will remove a pseudo header of 1 byte,
  then the lapb module will prepend the LAPB header of 2 or 3 bytes.
So the value of needed_headroom in this driver should be 3 - 1.

Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Martin Schiller <ms@dev.tdt.de>
Signed-off-by: Xie He <xie.he.0141@gmail.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/x25_asy.c