OSDN Git Service

afs: Fix warning due to unadvanced marshalling pointer
authorDavid Howells <dhowells@redhat.com>
Tue, 3 Nov 2020 16:32:58 +0000 (16:32 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 3 Nov 2020 17:53:40 +0000 (09:53 -0800)
commitc80afa1d9c3603d5eddeb8d63368823b1982f3f0
tree8be2ab8d7008001f79e6ef0dd23baa075044fc4a
parent90bfdeef83f1d6c696039b6a917190dcbbad3220
afs: Fix warning due to unadvanced marshalling pointer

When using the afs.yfs.acl xattr to change an AuriStor ACL, a warning
can be generated when the request is marshalled because the buffer
pointer isn't increased after adding the last element, thereby
triggering the check at the end if the ACL wasn't empty.  This just
causes something like the following warning, but doesn't stop the call
from happening successfully:

    kAFS: YFS.StoreOpaqueACL2: Request buffer underflow (36<108)

Fix this simply by increasing the count prior to the check.

Fixes: f5e4546347bc ("afs: Implement YFS ACL setting")
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/afs/yfsclient.c