OSDN Git Service

cxgb4: cxgb4_tc_u32: use struct_size() in kvzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 29 Jan 2019 17:05:23 +0000 (11:05 -0600)
committerDavid S. Miller <davem@davemloft.net>
Tue, 29 Jan 2019 18:55:25 +0000 (10:55 -0800)
commitc829f5f52db9bae0379b98fca2645f6ca9b0fb1e
treeacbedc1085b4fc1952010c9b5febd01e2563e25d
parent9f672984338d160aa262be7ad6d19fd182dc384d
cxgb4: cxgb4_tc_u32: use struct_size() in kvzalloc()

One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

instance = kvzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:

instance = kvzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c