OSDN Git Service

gpio: merrifield: check the return value of devm_kstrdup()
authorXiaoke Wang <xkernel.wang@foxmail.com>
Mon, 17 Jan 2022 07:06:06 +0000 (15:06 +0800)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 24 Jan 2022 15:23:15 +0000 (17:23 +0200)
commitc84eab5850d11bea546491bb1798039448971141
tree3ca0044aef6715d2e7d899e4c8d7804b96108fff
parent06608bc2d9e6f5a24baf51951e9e2fff3ec78e54
gpio: merrifield: check the return value of devm_kstrdup()

devm_kstrdup() returns pointer to allocated string on success, NULL on
failure. So it is better to check the return value of it.

Before, if devm_kstrdup() fails, pinctrl_dev_name will be NULL, then the
retval below will be a negative error-code (inside gpiochip_add_pin_range(),
pinctrl_find_and_add_gpio_range()->get_pinctrl_dev_from_devname() will
finally check pinctrl_dev_name and return an error), so the failure of
devm_kstrdup() can be only implicitly caught after a long call chain.

While this patch is to explicitly catch the failure in time.

Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/gpio/gpio-merrifield.c