OSDN Git Service

can: sja1000: Replace mdelay with usleep_range in pcan_add_channels
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 11 Apr 2018 01:43:26 +0000 (09:43 +0800)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 27 Jul 2018 08:40:17 +0000 (10:40 +0200)
commitc8d4dea2a82b0e1c695646aaabdada130ab71f79
treeee0b9643133f050e3809a15e720d0e11306bcf0c
parent276b7361bb1be3dccbc10b5be93cfee4bef2249c
can: sja1000: Replace mdelay with usleep_range in pcan_add_channels

pcan_add_channels() is never called in atomic context.

pcan_add_channels() is only called by pcan_probe(), which is only set as
".probe" in struct pcmcia_driver.

Despite never getting called from atomic context, pcan_add_channels()
calls mdelay() to busily wait.
This is not necessary and can be replaced with usleep_range() to
avoid busy waiting.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/sja1000/peak_pcmcia.c