OSDN Git Service

lib/mpi: Fix karactx leak in mpi_powm
authorHerbert Xu <herbert@gondor.apana.org.au>
Mon, 24 Jun 2019 10:32:26 +0000 (18:32 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 3 Jul 2019 14:11:55 +0000 (22:11 +0800)
commitc8ea9fce2baf7b643384f36f29e4194fa40d33a6
treeac6c28eff7d957212a01d18d2dc932ef9b54b3a6
parent7829a0c1cb9c80debfb4fdb49b4d90019f2ea1ac
lib/mpi: Fix karactx leak in mpi_powm

Sometimes mpi_powm will leak karactx because a memory allocation
failure causes a bail-out that skips the freeing of karactx.  This
patch moves the freeing of karactx to the end of the function like
everything else so that it can't be skipped.

Reported-by: syzbot+f7baccc38dcc1e094e77@syzkaller.appspotmail.com
Fixes: cdec9cb5167a ("crypto: GnuPG based MPI lib - source files...")
Cc: <stable@vger.kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Reviewed-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
lib/mpi/mpi-pow.c