OSDN Git Service

qlcnic: fix a return in qlcnic_dcb_get_capability()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 19 Oct 2018 20:11:11 +0000 (23:11 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 23 Oct 2018 02:34:16 +0000 (19:34 -0700)
commitc94f026fb742b2d3199422751dbc4f6fc0e753d8
tree42ed85d44adbfc3d235f45c6a627758187d466d1
parentde46e92af4461decff2288a1e97e47cd9e82f783
qlcnic: fix a return in qlcnic_dcb_get_capability()

These functions are supposed to return one on failure and zero on
success.  Returning a zero here could cause uninitialized variable
bugs in several of the callers.  For example:

    drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:1660 get_iscsi_dcb_priority()
    error: uninitialized symbol 'caps'.

Fixes: 48365e485275 ("qlcnic: dcb: Add support for CEE Netlink interface.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c