OSDN Git Service

EDAC, sb_edac: Fix signedness bugs in *_get_ha() functions
authorLuck, Tony <tony.luck@intel.com>
Fri, 14 Sep 2018 20:19:05 +0000 (13:19 -0700)
committerBorislav Petkov <bp@suse.de>
Sat, 15 Sep 2018 09:41:08 +0000 (11:41 +0200)
commitc968ed08594dadb788a93dc2bc128ed4ef35c93e
tree8448f6d981ed72aa90061e962a74622364989476
parent8489b17ce29d9a35a36c08bbea93cdce4c98a6ad
EDAC, sb_edac: Fix signedness bugs in *_get_ha() functions

A static checker gave the following warnings:

  drivers/edac/sb_edac.c:1030 ibridge_get_ha() warn: signedness bug returning '(-22)'
  drivers/edac/sb_edac.c:1037 knl_get_ha() warn: signedness bug returning '(-22)'

Both because the functions are declared to return a "u8", but try to
return -EINVAL for the error case.

Fix by returning 0xff (since the caller doesn't look at, or pass on, the
return value).

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Cc: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20180914201905.GA30946@agluck-desk
Signed-off-by: Borislav Petkov <bp@suse.de>
drivers/edac/sb_edac.c