OSDN Git Service

mmc: tmio: remove useless TMIO_MASK_CMD handling in tmio_mmc_host_probe()
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Wed, 17 Jan 2018 16:28:16 +0000 (01:28 +0900)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 5 Mar 2018 12:04:27 +0000 (13:04 +0100)
commitc9b929edf4e1f96c550584fe8445755b6d600e71
tree688882f4109fd45aebb05ce2cd046c7f5dd69c51
parent9b3ab55dbabd8bc8ac226a603f02ad39e6202521
mmc: tmio: remove useless TMIO_MASK_CMD handling in tmio_mmc_host_probe()

TMIO_MASK_CMD is properly enabled in tmio_mmc_start_command().

We have no reason to set it up in tmio_mmc_host_probe().  (If we
really wanted to set it in the probe, we would have to do likewise
when resuming.)

Even worse, the following code is extremely confusing:

  _host->sdcard_irq_mask &= ~irq_mask;

The logic is opposite between "->sdcard_irq_mask" and "irq_mask".
The intention is not clear at a glance.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/tmio_mmc_core.c