OSDN Git Service

drm/mipi-dsi: Fix byte order of 16-bit DCS set/get brightness
authorDaniel Mentz <danielmentz@google.com>
Mon, 16 Jan 2023 22:49:07 +0000 (17:49 -0500)
committerNeil Armstrong <neil.armstrong@linaro.org>
Thu, 19 Jan 2023 07:21:56 +0000 (08:21 +0100)
commitc9d27c6be518b4ef2966d9564654ef99292ea1b3
treeb769f4c4a7dda23e06df6ee7efc9d624327cd195
parent13acb368bf02c4ab2c3bd7c35629b421b0ceed18
drm/mipi-dsi: Fix byte order of 16-bit DCS set/get brightness

The MIPI DCS specification demands that brightness values are sent in
big endian byte order. It also states that one parameter (i.e. one byte)
shall be sent/received for 8 bit wide values, and two parameters shall
be used for values that are between 9 and 16 bits wide.

Add new functions to properly handle 16-bit brightness in big endian,
since the two 8- and 16-bit cases are distinct from each other.

[richard: use separate functions instead of switch/case]
[richard: split into 16-bit component]

Fixes: 1a9d759331b8 ("drm/dsi: Implement DCS set/get display brightness")
Signed-off-by: Daniel Mentz <danielmentz@google.com>
Link: https://android.googlesource.com/kernel/msm/+/754affd62d0ee268c686c53169b1dbb7deac8550
[richard: fix 16-bit brightness_get]
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
Tested-by: Caleb Connolly <caleb@connolly.tech>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230116224909.23884-2-mailingradian@gmail.com
drivers/gpu/drm/drm_mipi_dsi.c
include/drm/drm_mipi_dsi.h