OSDN Git Service

net: ipconfig: Avoid spurious blank lines in boot log
authorThierry Reding <treding@nvidia.com>
Tue, 10 Nov 2020 07:37:57 +0000 (08:37 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 12 Nov 2020 22:53:33 +0000 (14:53 -0800)
commitc9f64d1fc101c64ea2be1b2e562b4395127befc9
tree4ba047ee5efe32fe3835d9cf857286eddc3e01ed
parent203cb737fbe09cc6b57d4bd46be7977e72d49281
net: ipconfig: Avoid spurious blank lines in boot log

When dumping the name and NTP servers advertised by DHCP, a blank line
is emitted if either of the lists is empty. This can lead to confusing
issues such as the blank line getting flagged as warning. This happens
because the blank line is the result of pr_cont("\n") and that may see
its level corrupted by some other driver concurrently writing to the
console.

Fix this by making sure that the terminating newline is only emitted
if at least one entry in the lists was printed before.

Reported-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20201110073757.1284594-1-thierry.reding@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/ipconfig.c