OSDN Git Service

regulator: tps6594-regulator: Fix random kernel crash
authorJerome Neanne <jneanne@baylibre.com>
Tue, 5 Sep 2023 14:07:34 +0000 (16:07 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 5 Sep 2023 19:58:41 +0000 (20:58 +0100)
commitca0e36e3e39a4e8b5a4b647dff8c5938ca6ccbec
tree3f81afbf22854a3eb891c44207d71bb5feee445d
parentc69290557c7571dff3d995fa27619b965915e8a1
regulator: tps6594-regulator: Fix random kernel crash

Random kernel crash detected in TI CICD when regulator driver is added.
This is root caused to irq index increment being done twice causing
irq_data being allocated outside of the range.

- Rework tps6594_request_reg_irqs with correct index increment
- Adjust irq_data kmalloc size to the exact size needed for the device

This has been reported on TI mainline. No public bug report associated.

Reported-by: Udit Kumar <u-kumar1@ti.com>
Fixes: f17ccc5deb4d ("regulator: tps6594-regulator: Add driver for TI TPS6594 regulators")
Signed-off-by: Jerome Neanne <jneanne@baylibre.com>
Link: https://lore.kernel.org/r/20230828-tps6594_random_boot_crash_fix-v1-1-f29cbf9ddb37@baylibre.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/tps6594-regulator.c