OSDN Git Service

batman-adv: fix warning in function batadv_v_elp_get_throughput
authorAnders Roxell <anders.roxell@linaro.org>
Fri, 22 Feb 2019 15:25:54 +0000 (16:25 +0100)
committerSimon Wunderlich <sw@simonwunderlich.de>
Mon, 25 Mar 2019 08:31:19 +0000 (09:31 +0100)
commitca8c3b922e7032aff6cc3fd05548f4df1f3df90e
treeeef3248d5c1f186aa83aa5865e88cfd2a37db73c
parentf131a56880d10932931e74773fb8702894a94a75
batman-adv: fix warning in function batadv_v_elp_get_throughput

When CONFIG_CFG80211 isn't enabled the compiler correcly warns about
'sinfo.pertid' may be unused. It can also happen for other error
conditions that it not warn about.

net/batman-adv/bat_v_elp.c: In function ‘batadv_v_elp_get_throughput.isra.0’:
include/net/cfg80211.h:6370:13: warning: ‘sinfo.pertid’ may be used
 uninitialized in this function [-Wmaybe-uninitialized]
  kfree(sinfo->pertid);
        ~~~~~^~~~~~~~

Rework so that we only release '&sinfo' if cfg80211_get_station returns
zero.

Fixes: 7d652669b61d ("batman-adv: release station info tidstats")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
net/batman-adv/bat_v_elp.c