OSDN Git Service

visorbus: fix uninitialized variable access
authorArnd Bergmann <arnd@arndb.de>
Tue, 7 Jan 2020 20:29:40 +0000 (21:29 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jan 2020 14:30:35 +0000 (15:30 +0100)
commitcaf82f727e69b647f09d57a1fc56e69d22a5f483
treedec26a2eb22c0ef085de229d7c7b674965cbd3f3
parent34bc4f468a9fab1e8c85f05117a0d46adec2c200
visorbus: fix uninitialized variable access

The setup_crash_devices_work_queue function only partially initializes
the message it sends to chipset_init, leading to undefined behavior:

drivers/visorbus/visorchipset.c: In function 'setup_crash_devices_work_queue':
drivers/visorbus/visorchipset.c:333:6: error: '((unsigned char*)&msg.hdr.flags)[0]' is used uninitialized in this function [-Werror=uninitialized]
  if (inmsg->hdr.flags.response_expected)

Set up the entire structure, zero-initializing the 'response_expected'
flag.

This was apparently found by the patch that added the -O3 build option
in Kconfig.

Fixes: 12e364b9f08a ("staging: visorchipset driver to provide registration and other services")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20200107202950.782951-1-arnd@arndb.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/visorbus/visorchipset.c