OSDN Git Service

netlink: extack needs to be reset each time through loop
authorDavid Ahern <dsahern@gmail.com>
Wed, 10 Jan 2018 21:00:39 +0000 (13:00 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Jan 2018 18:50:07 +0000 (13:50 -0500)
commitcbbdf8433a5f117b1a2119ea30fc651b61ef7570
treef8db54b9ab381bbde880ab1d2b869730c48a3eaf
parent59b36613e85fb16ebf9feaf914570879cd5c2a21
netlink: extack needs to be reset each time through loop

syzbot triggered the WARN_ON in netlink_ack testing the bad_attr value.
The problem is that netlink_rcv_skb loops over the skb repeatedly invoking
the callback and without resetting the extack leaving potentially stale
data. Initializing each time through avoids the WARN_ON.

Fixes: 2d4bc93368f5a ("netlink: extended ACK reporting")
Reported-by: syzbot+315fa6766d0f7c359327@syzkaller.appspotmail.com
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlink/af_netlink.c