OSDN Git Service

phylib: fix potential use-after-free
authorMarek Behún <kabel@kernel.org>
Wed, 19 Jan 2022 16:27:48 +0000 (17:27 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 21 Jan 2022 04:17:04 +0000 (20:17 -0800)
commitcbda1b16687580d5beee38273f6241ae3725960c
tree1520342dfc5e821776655ba90c756ec6beb88939
parent57afdc0aab094b4c811b3fe030b2567812a495f3
phylib: fix potential use-after-free

Commit bafbdd527d56 ("phylib: Add device reset GPIO support") added call
to phy_device_reset(phydev) after the put_device() call in phy_detach().

The comment before the put_device() call says that the phydev might go
away with put_device().

Fix potential use-after-free by calling phy_device_reset() before
put_device().

Fixes: bafbdd527d56 ("phylib: Add device reset GPIO support")
Signed-off-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20220119162748.32418-1-kabel@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/phy_device.c