OSDN Git Service

net: dsa: mv88e6xxx: fix speed setting for CPU/DSA ports
authorMarcin Wojtas <mw@semihalf.com>
Tue, 26 Jul 2022 23:09:18 +0000 (01:09 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 28 Jul 2022 02:58:34 +0000 (19:58 -0700)
commitcc1049ccee20df870f2394c4d5d5fa8cabc4d0af
tree5ed24f9f499c6938dc669806e2c9add365b122e3
parent2bb88b2c4f7334bd91c734f3983492a133250edb
net: dsa: mv88e6xxx: fix speed setting for CPU/DSA ports

Commit 3c783b83bd0f ("net: dsa: mv88e6xxx: get rid of SPEED_MAX setting")
stopped relying on SPEED_MAX constant and hardcoded speed settings
for the switch ports and rely on phylink configuration.

It turned out, however, that when the relevant code is called,
the mac_capabilites of CPU/DSA port remain unset.
mv88e6xxx_setup_port() is called via mv88e6xxx_setup() in
dsa_tree_setup_switches(), which precedes setting the caps in
phylink_get_caps down in the chain of dsa_tree_setup_ports().

As a result the mac_capabilites are 0 and the default speed for CPU/DSA
port is 10M at the start. To fix that, execute mv88e6xxx_get_caps()
and obtain the capabilities driectly.

Fixes: 3c783b83bd0f ("net: dsa: mv88e6xxx: get rid of SPEED_MAX setting")
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20220726230918.2772378-1-mw@semihalf.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/mv88e6xxx/chip.c