OSDN Git Service

net: ll_temac: Fix potential NULL dereference in temac_probe()
authorZhang Changzhong <zhangchangzhong@huawei.com>
Tue, 8 Dec 2020 01:53:42 +0000 (09:53 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 9 Dec 2020 00:15:46 +0000 (16:15 -0800)
commitcc6596fc7295e9dcd78156ed42f9f8e1221f7530
treee7a274e333a77b28c752fd722e0da45d90127ad0
parent0398ba9e5a4b5675aa571e0445689d3c2e499c2d
net: ll_temac: Fix potential NULL dereference in temac_probe()

platform_get_resource() may fail and in this case a NULL dereference
will occur.

Fix it to use devm_platform_ioremap_resource() instead of calling
platform_get_resource() and devm_ioremap().

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = \(platform_get_resource\|platform_get_resource_byname\)(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Fixes: 8425c41d1ef7 ("net: ll_temac: Extend support to non-device-tree platforms")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Acked-by: Esben Haabendal <esben@geanix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/xilinx/ll_temac_main.c