OSDN Git Service

r8169: fix WoL on shutdown if CONFIG_DEBUG_SHIRQ is set
authorHeiner Kallweit <hkallweit1@gmail.com>
Mon, 1 Feb 2021 20:50:56 +0000 (21:50 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 2 Feb 2021 16:44:15 +0000 (08:44 -0800)
commitcc9f07a838c4988ed244d0907cb71d54b85482a5
treea9803cb8da1e6d3474351c46e4ff7176c814dc74
parenta11148e6fcce2ae53f47f0a442d098d860b4f7db
r8169: fix WoL on shutdown if CONFIG_DEBUG_SHIRQ is set

So far phy_disconnect() is called before free_irq(). If CONFIG_DEBUG_SHIRQ
is set and interrupt is shared, then free_irq() creates an "artificial"
interrupt by calling the interrupt handler. The "link change" flag is set
in the interrupt status register, causing phylib to eventually call
phy_suspend(). Because the net_device is detached from the PHY already,
the PHY driver can't recognize that WoL is configured and powers down the
PHY.

Fixes: f1e911d5d0df ("r8169: add basic phylib support")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/fe732c2c-a473-9088-3974-df83cfbd6efd@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/realtek/r8169_main.c