OSDN Git Service

drm: Always prepare null framebuffer in transitional helper
authorGabriel Krisman Bertazi <krisman@collabora.co.uk>
Thu, 16 Feb 2017 16:44:42 +0000 (14:44 -0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Sun, 26 Feb 2017 20:57:24 +0000 (21:57 +0100)
commitcd2523569a733d85788b6fc016e4e23cb3549a25
tree378a35ff0ea197ed9cee5bbe4d73108df23b87c6
parent3c6d6e0fbf5eb6367dfc8a97f72bd625e78b1aae
drm: Always prepare null framebuffer in transitional helper

Despite the documentation claim that cleanup_fb will match prior calls
to prepare_fb, in case of NULL framebuffers in the transitional helpers,
the code will skip the call to prepare_fb but not the corresponding
cleanup_fb call.  This asymmetry in semantics is unnecessarily surprising
for developers transitioning drivers to atomic model, specially because
the final atomic handlers don't have the issue - the prepare_fb is
always called, despite the new state framebuffer being null.

The only current user of the transitional helper that doesn't take care
of null framebuffers explicitly inside the prepare_fb hook is
atmel_hlcdc, so we take special care to make sure we don't break
anything there.

Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20170216164442.28704-1-krisman@collabora.co.uk
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
drivers/gpu/drm/drm_plane_helper.c