OSDN Git Service

f2fs: fix potential hangtask in f2fs_trace_pid
authorChao Yu <yuchao0@huawei.com>
Tue, 12 Dec 2017 06:11:40 +0000 (14:11 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Thu, 8 Feb 2018 02:05:37 +0000 (18:05 -0800)
commitcd38d5ada5a4dcad36e9791a279cecc3de57bd13
tree9c85e5203f50ece17ea55c97d3c2c48c23e60975
parente81cafbeba4bf252b24778a17aef3f623a0815e3
f2fs: fix potential hangtask in f2fs_trace_pid

As Jia-Ju Bai reported:

"According to fs/f2fs/trace.c, the kernel module may sleep under a spinlock.
The function call path is:
f2fs_trace_pid (acquire the spinlock)
   f2fs_radix_tree_insert
     cond_resched --> may sleep

I do not find a good way to fix it, so I only report.
This possible bug is found by my static analysis tool (DSAC) and my code
review."

Obviously, it's problemetic to schedule in critical region of spinlock,
which will cause uninterruptable sleep if there is no waker.

This patch changes to use mutex lock intead of spinlock to avoid this
condition.

Reported-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/trace.c