OSDN Git Service

drm/i915: do not stop engines on sanitize if i915.reset=0
authorDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Wed, 7 Feb 2018 21:24:40 +0000 (13:24 -0800)
committerChris Wilson <chris@chris-wilson.co.uk>
Thu, 8 Feb 2018 07:34:32 +0000 (07:34 +0000)
commitce1599a40da20b0e5e4175fe3ef647d2862cbf41
tree6d08c3d5318b0ee86fa34c4b3c26412f9ba00917
parentd63763749127b483ba042b2939ba39fd79792330
drm/i915: do not stop engines on sanitize if i915.reset=0

Since commit 5896a5c8c9c0 (drm/i915: Always stop the rings before a
missing GPU reset) we attempt to stop the engines during gem_sanitize
even if reset=0 and nothing bad happened on the gpu.
The specs says that the STOP_RINGS bit needs to be cleared to resume
normal operation, but for some reason the value of the bit seems to be
changing without us writing to it (maybe rc6 entry/exit?), so normal
operation resumes correctly. However, it still feels incorrect to stop
the engines if there hasn't been any issue so skip the whole reset
call in gem_sanitize if i915.reset=0

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180207212440.13438-1-daniele.ceraolospurio@intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
drivers/gpu/drm/i915/i915_gem.c