OSDN Git Service

btrfs: don't double unlock on error in btrfs_punch_hole
authorJosef Bacik <josef@toxicpanda.com>
Fri, 3 May 2019 15:10:06 +0000 (11:10 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 31 May 2019 13:46:02 +0000 (06:46 -0700)
commitce21e6586eece6502da23a9c275a60f2fdf8b8b8
tree1761b78dc80586cd54d07f1749e213aae260e1f3
parentfdc78eedc54d3d4eb0c3cd747226e5e9948fa860
btrfs: don't double unlock on error in btrfs_punch_hole

commit 8fca955057b9c58467d1b231e43f19c4cf26ae8c upstream.

If we have an error writing out a delalloc range in
btrfs_punch_hole_lock_range we'll unlock the inode and then goto
out_only_mutex, where we will again unlock the inode.  This is bad,
don't do this.

Fixes: f27451f22996 ("Btrfs: add support for fallocate's zero range operation")
CC: stable@vger.kernel.org # 4.19+
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/btrfs/file.c