OSDN Git Service

serdev: ttyport: fix tty locking in close
authorJohan Hovold <johan@kernel.org>
Fri, 3 Nov 2017 14:30:56 +0000 (15:30 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 14 Dec 2017 08:52:44 +0000 (09:52 +0100)
commitce42ed5ae8982360dba581acfafdaff88f2b3fbe
treeb19babb995b1f95337fb29c0dbdef2204011078e
parent5a3da8bd93c78b6a4aed19c83cb8f493dfc4dfef
serdev: ttyport: fix tty locking in close

commit 90dbad8cd6efccbdce109d5ef0724f8434a6cdde upstream.

Make sure to hold the tty lock as required when calling tty-driver
close() (e.g. to avoid racing with hangup()).

Note that the serport active flag is currently set under the lock at
controller open, but really isn't protected by it.

Fixes: cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serdev/serdev-ttyport.c