OSDN Git Service

net: phylink: move phy_device_free() to correctly release phy device
authorClément Léger <clement.leger@bootlin.com>
Tue, 31 Jan 2023 10:02:42 +0000 (11:02 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Feb 2023 09:13:53 +0000 (09:13 +0000)
commitce93fdb5f2ca5c9e2a9668411cc39091507f8dc9
treec6dc4f05a63c75031677976545deb6c6b81ef96b
parentedb9b8f380c3413bf783475279b1a941c7e5cec1
net: phylink: move phy_device_free() to correctly release phy device

After calling fwnode_phy_find_device(), the phy device refcount is
incremented. Then, when the phy device is attached to a netdev with
phy_attach_direct(), the refcount is also incremented but only
decremented in the caller if phy_attach_direct() fails. Move
phy_device_free() before the "if" to always release it correctly.
Indeed, either phy_attach_direct() failed and we don't want to keep a
reference to the phydev or it succeeded and a reference has been taken
internally.

Fixes: 25396f680dd6 ("net: phylink: introduce phylink_fwnode_phy_connect()")
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phylink.c