OSDN Git Service

tracing: Fix to check event_mutex is held while accessing trigger list
authorMasami Hiramatsu (Google) <mhiramat@kernel.org>
Sun, 4 Sep 2022 04:12:29 +0000 (13:12 +0900)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Wed, 7 Sep 2022 02:26:00 +0000 (22:26 -0400)
commitcecf8e128ec69149fe53c9a7bafa505a4bee25d9
tree99abc155af355e9e41bd14ec58905795756c4d2f
parent54c3931957f6a6194d5972eccc36d052964b2abe
tracing: Fix to check event_mutex is held while accessing trigger list

Since the check_user_trigger() is called outside of RCU
read lock, this list_for_each_entry_rcu() caused a suspicious
RCU usage warning.

 # echo hist:keys=pid > events/sched/sched_stat_runtime/trigger
 # cat events/sched/sched_stat_runtime/trigger
[   43.167032]
[   43.167418] =============================
[   43.167992] WARNING: suspicious RCU usage
[   43.168567] 5.19.0-rc5-00029-g19ebe4651abf #59 Not tainted
[   43.169283] -----------------------------
[   43.169863] kernel/trace/trace_events_trigger.c:145 RCU-list traversed in non-reader section!!
...

However, this file->triggers list is safe when it is accessed
under event_mutex is held.
To fix this warning, adds a lockdep_is_held check to the
list_for_each_entry_rcu().

Link: https://lkml.kernel.org/r/166226474977.223837.1992182913048377113.stgit@devnote2
Cc: stable@vger.kernel.org
Fixes: 7491e2c44278 ("tracing: Add a probe that attaches to trace events")
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_events_trigger.c