OSDN Git Service

drm/amdkfd: fix null pointer dereference on dev
authorColin Ian King <colin.king@canonical.com>
Wed, 29 May 2019 15:07:34 +0000 (16:07 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 29 May 2019 21:50:09 +0000 (16:50 -0500)
commitcf401e2856b27b2deeada498eab864e2a50cf219
treeb53ebd525a0c1e79772a47fbeb419035d680bbde
parent394e9a14c63d58e0f45323629a3f9ce1e5bf0215
drm/amdkfd: fix null pointer dereference on dev

The pointer dev is set to null yet it is being dereferenced when
checking dev->dqm->sched_policy.  Fix this by performing the check
on dev->dqm->sched_policy after dev has been assigned and null
checked.  Also remove the redundant null assignment to dev.

Addresses-Coverity: ("Explicit null dereference")
Fixes: 1a058c337676 ("drm/amdkfd: New IOCTL to allocate queue GWS")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c