OSDN Git Service

netfilter: nft_exthdr: Fix for unsafe packet data read
authorPhil Sutter <phil@nwl.cc>
Tue, 8 Jun 2021 09:40:57 +0000 (11:40 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 9 Jun 2021 00:42:52 +0000 (02:42 +0200)
commitcf6b5ffdce5a78b2fcb0e53b3a2487c490bcbf7f
treebf2d722476e0f24697c80ca97d77172fe4caea26
parente2cf17d3774c323ef6dab6e9f7c0cfc5e742afd9
netfilter: nft_exthdr: Fix for unsafe packet data read

While iterating through an SCTP packet's chunks, skb_header_pointer() is
called for the minimum expected chunk header size. If (that part of) the
skbuff is non-linear, the following memcpy() may read data past
temporary buffer '_sch'. Use skb_copy_bits() instead which does the
right thing in this situation.

Fixes: 133dc203d77df ("netfilter: nft_exthdr: Support SCTP chunks")
Suggested-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Phil Sutter <phil@nwl.cc>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nft_exthdr.c