OSDN Git Service

media: sun4i-csi: Fix data sampling polarity handling
authorChen-Yu Tsai <wens@csie.org>
Sun, 15 Dec 2019 16:59:13 +0000 (17:59 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sat, 4 Jan 2020 07:17:14 +0000 (08:17 +0100)
commitcf9e6d5dbdd56ef2aa72f28c806711c4293c8848
tree71a9a641e9ae76188c7272fc182edc08f2e37062
parent7866d6903ce88b1b359202f4be0422aa6a70a4a2
media: sun4i-csi: Fix data sampling polarity handling

The CLK_POL field specifies whether data is sampled on the falling or
rising edge of PCLK, not whether the data lines are active high or low.
Evidence of this can be found in the timing diagram labeled "horizontal
size setting and pixel clock timing".

Fix the setting by checking the correct flag, V4L2_MBUS_PCLK_SAMPLE_RISING.
While at it, reorder the three polarity flag checks so HSYNC and VSYNC
are grouped together.

Fixes: 577bbf23b758 ("media: sunxi: Add A10 CSI driver")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c