OSDN Git Service

genetlink: reject use of nlmsg_flags for new commands
authorJakub Kicinski <kuba@kernel.org>
Thu, 29 Sep 2022 14:28:09 +0000 (07:28 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 1 Oct 2022 00:43:09 +0000 (17:43 -0700)
commitcff2d762cde669023f345157f875b7ea6658992a
treee86e6a63dfb3a73cfd8ede815601e719044c51f8
parent915b96c52763e2988e6368b538b487a7138b8fa4
genetlink: reject use of nlmsg_flags for new commands

Commit 9c5d03d36251 ("genetlink: start to validate reserved header bytes")
introduced extra validation for genetlink headers. We had to gate it
to only apply to new commands, to maintain bug-wards compatibility.
Use this opportunity (before the new checks make it to Linus's tree)
to add more conditions.

Validate that Generic Netlink families do not use nlmsg_flags outside
of the well-understood set.

Link: https://lore.kernel.org/all/20220928073709.1b93b74a@kernel.org/
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Reviewed-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Reviewed-by: Guillaume Nault <gnault@redhat.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://lore.kernel.org/r/20220929142809.1167546-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/netlink/genetlink.c