OSDN Git Service

regulator: max77686: Let core handle GPIO descriptor
authorLinus Walleij <linus.walleij@linaro.org>
Thu, 6 Dec 2018 12:43:43 +0000 (13:43 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 11 Dec 2018 01:04:08 +0000 (01:04 +0000)
commitd03c63dbcaa1ee570d0435a7f79c7083ffb59245
tree62ff650c161160ca4a524af4910b9aab5f1b98ab
parentfe6c473e3e41114301bfbf5710be56bf0eb233dc
regulator: max77686: Let core handle GPIO descriptor

Use the gpiod_get_from_of_node() rather than the devm_*
version so that the regulator core can handle the lifecycle
of these descriptors.

Fix up the errorpath so that we free this descriptor if
an error occurs in the callback. Rely on the regulator
core to deal with it after this point: a previous patch
fixed up the regulator core to properly dispose any
GPIO descriptors once you call regulator_register().

Fixes: 96392c3d8ca4 ("regulator: max77686: Pass descriptor instead of GPIO number")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/max77686-regulator.c