OSDN Git Service

ftrace: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Wed, 17 May 2023 14:53:23 +0000 (14:53 +0000)
committerKees Cook <keescook@chromium.org>
Tue, 30 May 2023 23:42:00 +0000 (16:42 -0700)
commitd0c2d66fcc8db748edfe60e3b443eaff931f50e9
treedb83cf7004fae6d5cdf93b796deeeb025f9fc3ad
parentdd06e72e68bcb4070ef211be100d2896e236c8fb
ftrace: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230517145323.1522010-1-azeemshaikh38@gmail.com
kernel/trace/ftrace.c