OSDN Git Service

clocksource/drivers/arm_arch_timer: Fix mem frame loop initialization
authorMatthias Kaehlcke <mka@chromium.org>
Mon, 31 Jul 2017 18:37:28 +0000 (11:37 -0700)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Thu, 10 Aug 2017 12:48:17 +0000 (14:48 +0200)
commitd197f7988721221fac64f899efd7657c15281810
tree82d4093b5b9c6cda12750553442887be788f0f2a
parent34f41c0316ed52b0b44542491d89278efdaa70e4
clocksource/drivers/arm_arch_timer: Fix mem frame loop initialization

The loop to find the best memory frame in arch_timer_mem_acpi_init()
initializes the loop counter with itself ('i = i'), which is suspicious
in the first place and pointed out by clang. The loop condition is
'i < timer_count' and a prior for loop exits when 'i' reaches
'timer_count', therefore the second loop is never executed.

Initialize the loop counter with 0 to iterate over all timers, which
supposedly was the intention before the typo monster attacked.

Fixes: c2743a36765d3 ("clocksource: arm_arch_timer: add GTDT support for memory-mapped timer")
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reported-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/clocksource/arm_arch_timer.c