OSDN Git Service

dma-buf: Make locking consistent in dma_buf_detach()
authorDmitry Osipenko <dmitry.osipenko@collabora.com>
Sun, 30 Oct 2022 15:44:11 +0000 (18:44 +0300)
committerDmitry Osipenko <dmitry.osipenko@collabora.com>
Wed, 2 Nov 2022 10:52:38 +0000 (13:52 +0300)
commitd3292daee319581d0a502fcd8ef3c3c285a1750a
tree5a9d686cfb246c4312757b23ae2e8653ea34a764
parent387659939c00156f8d6bab0fbc55b4eaf2b6bc5b
dma-buf: Make locking consistent in dma_buf_detach()

The dma_buf_detach() locks attach->dmabuf->resv and then unlocks
dmabuf->resv, which could be a two different locks from a static
code checker perspective. In particular this triggers Smatch to
report the "double unlock" error. Make the locking pointers consistent.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://lore.kernel.org/dri-devel/Y1fLfsccW3AS%2Fo+%2F@kili/
Fixes: 809d9c72c2f8 ("dma-buf: Move dma_buf_attach() to dynamic locking specification")
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221030154412.8320-2-dmitry.osipenko@collabora.com
drivers/dma-buf/dma-buf.c