OSDN Git Service

Revert "drivers/net/wan/hdlc_fr: Fix a double free in pvc_xmit"
authorXie He <xie.he.0141@gmail.com>
Mon, 3 May 2021 03:51:36 +0000 (20:51 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 May 2021 20:37:58 +0000 (13:37 -0700)
commitd362fd0be456dba2d3d58a90b7a193962776562b
tree2e93152ce85df8ab7dd6caea4ef7e6e9f74281a0
parentd89ecd154c23dbee3461efaceaa60263cc9e8fee
Revert "drivers/net/wan/hdlc_fr: Fix a double free in pvc_xmit"

This reverts commit 1b479fb80160
("drivers/net/wan/hdlc_fr: Fix a double free in pvc_xmit").

1. This commit is incorrect. "__skb_pad" will NOT free the skb on
failure when its "free_on_error" parameter is "false".

2. This commit claims to fix my commit. But it didn't CC me??

Fixes: 1b479fb80160 ("drivers/net/wan/hdlc_fr: Fix a double free in pvc_xmit")
Cc: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Signed-off-by: Xie He <xie.he.0141@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/hdlc_fr.c