OSDN Git Service

aio: use g_slice_alloc() for AIOCB pooling
authorStefan Hajnoczi <stefanha@redhat.com>
Wed, 31 Oct 2012 15:34:36 +0000 (16:34 +0100)
committerKevin Wolf <kwolf@redhat.com>
Wed, 14 Nov 2012 17:19:21 +0000 (18:19 +0100)
commitd37c975fb134e1b16f09b4e6545e2c0591fb6455
tree284796e24c44051fe9ff58b910d48d34e5184211
parent8c82e9a4331bad42dfc01158fbd1e8f4c2f1c957
aio: use g_slice_alloc() for AIOCB pooling

AIO control blocks are frequently acquired and released because each aio
request involves at least one AIOCB.  Therefore, we pool them to avoid
heap allocation overhead.

The problem with the freelist approach in AIOPool is thread-safety.  If
we want BlockDriverStates to associate with AioContexts that execute in
multiple threads, then a global freelist becomes a problem.

This patch drops the freelist and instead uses g_slice_alloc() which is
tuned for per-thread fixed-size object pools.  qemu_aio_get() and
qemu_aio_release() are now thread-safe.

Note that the change from g_malloc0() to g_slice_alloc() should be safe
since the freelist reuse case doesn't zero the AIOCB either.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c
qemu-aio.h