OSDN Git Service

iommu/iova: Don't BUG on invalid PFNs
authorRobin Murphy <robin.murphy@arm.com>
Tue, 2 Jun 2020 13:08:18 +0000 (14:08 +0100)
committerJoerg Roedel <jroedel@suse.de>
Tue, 30 Jun 2020 08:42:27 +0000 (10:42 +0200)
commitd3e3d2be688b4b5864538de61e750721a311e4fc
tree18abb2488bd27e324197efd2e25e13dea0dcefba
parent9ebcfadb0610322ac537dd7aa5d9cbc2b2894c68
iommu/iova: Don't BUG on invalid PFNs

Unlike the other instances which represent a complete loss of
consistency within the rcache mechanism itself, or a fundamental
and obvious misconfiguration by an IOMMU driver, the BUG_ON() in
iova_magazine_free_pfns() can be provoked at more or less any time
in a "spooky action-at-a-distance" manner by any old device driver
passing nonsense to dma_unmap_*() which then propagates through to
queue_iova().

Not only is this well outside the IOVA layer's control, it's also
nowhere near fatal enough to justify panicking anyway - all that
really achieves is to make debugging the offending driver more
difficult. Let's simply WARN and otherwise ignore bogus PFNs.

Reported-by: Prakash Gupta <guptap@codeaurora.org>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Reviewed-by: Prakash Gupta <guptap@codeaurora.org>
Link: https://lore.kernel.org/r/acbd2d092b42738a03a21b417ce64e27f8c91c86.1591103298.git.robin.murphy@arm.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/iova.c