OSDN Git Service

net: ipv4: fix rcu lockdep splat due to wrong annotation
authorFlorian Westphal <fw@strlen.de>
Mon, 3 Jun 2019 20:41:44 +0000 (22:41 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 4 Jun 2019 21:24:10 +0000 (14:24 -0700)
commitd3e6e285fff3494a5c12154c8e7d79f5181d3ddc
treecde6818d92d666c803a42841832563f5324ca19c
parentae95f9c1a5601b3dd40d72436ef835b5bbb429a7
net: ipv4: fix rcu lockdep splat due to wrong annotation

syzbot triggered following splat when strict netlink
validation is enabled:

net/ipv4/devinet.c:1766 suspicious rcu_dereference_check() usage!

This occurs because we hold RTNL mutex, but no rcu read lock.
The second call site holds both, so just switch to the _rtnl variant.

Reported-by: syzbot+bad6e32808a3a97b1515@syzkaller.appspotmail.com
Fixes: 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/devinet.c