OSDN Git Service

tty: serial: qcom_geni_serial: Don't try to manually disable the console
authorDouglas Anderson <dianders@chromium.org>
Fri, 13 Mar 2020 20:46:52 +0000 (13:46 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Mar 2020 08:40:27 +0000 (09:40 +0100)
commitd49e7953f9b9f5e50c12dda95f4041fb877cdc71
treebc2d73b9f7a99d4eb31e2fe95edb948e8afec9a9
parente83766334f96b3396a71c7baa3b0b53dfd5190cd
tty: serial: qcom_geni_serial: Don't try to manually disable the console

The geni serial driver's shutdown code had a special case to call
console_stop().  Grepping through the code, it was the only serial
driver doing something like this (the only other caller of
console_stop() was in serial_core.c).

As far as I can tell there's no reason to call console_stop() in the
geni code.  ...and a good reason _not_ to call it.  Specifically if
you have an agetty running on the same serial port as the console then
killing the agetty kills your console and if you start the agetty
again the console doesn't come back.

Fixes: c4f528795d1a ("tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20200313134635.2.I3648fac6c98b887742934146ac2729ecb7232eb1@changeid
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/qcom_geni_serial.c