OSDN Git Service

drm/sched: Fix drm_sched_fence_free() so it can be passed an uninitialized fence
authorBoris Brezillon <boris.brezillon@collabora.com>
Fri, 3 Sep 2021 12:05:54 +0000 (14:05 +0200)
committerBoris Brezillon <boris.brezillon@collabora.com>
Tue, 7 Sep 2021 07:58:26 +0000 (09:58 +0200)
commitd4c16733e7960aa50d6d3bc4a03ee1578baaa47b
tree018f5f404e035d49e67ed13829cd4b878555eaa4
parent5bd785a8140333f9162438d0075edd1e432e7ef8
drm/sched: Fix drm_sched_fence_free() so it can be passed an uninitialized fence

drm_sched_job_cleanup() will pass an uninitialized fence to
drm_sched_fence_free(), which will cause to_drm_sched_fence() to return
a NULL fence object, causing a NULL pointer deref when this NULL object
is passed to kmem_cache_free().

Let's create a new drm_sched_fence_free() function that takes a
drm_sched_fence pointer and suffix the old function with _rcu. While at
it, complain if drm_sched_fence_free() is passed an initialized fence
or if drm_sched_fence_free_rcu() is passed an uninitialized fence.

Fixes: dbe48d030b28 ("drm/sched: Split drm_sched_job_init")
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210903120554.444101-1-boris.brezillon@collabora.com
drivers/gpu/drm/scheduler/sched_fence.c
drivers/gpu/drm/scheduler/sched_main.c
include/drm/gpu_scheduler.h