OSDN Git Service

ALSA: control: Take card->controls_rwsem in snd_ctl_rename()
authorTakashi Iwai <tiwai@suse.de>
Tue, 18 Jul 2023 14:12:54 +0000 (16:12 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 20 Jul 2023 08:00:02 +0000 (10:00 +0200)
commitd4e99962d16ce60ac9ecf995489dc60d7854f1bd
tree03356be7a3cac250abdc36bb20141385e2c217cc
parentfdf0eaf11452d72945af31804e2a1048ee1b574c
ALSA: control: Take card->controls_rwsem in snd_ctl_rename()

snd_ctl_rename() expects that card->controls_rwsem is held in the
caller side for avoiding possible races, but actually no one really
did that.  It's likely because this operation is done usually only at
the device initialization where no race can happen.  But, it's still
safer to take a lock, so we just take the lock inside snd_ctl_rename()
like most of other API functions do.

Link: https://lore.kernel.org/r/20230718141304.1032-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/control.c