OSDN Git Service

net: bgmac: fix BCM5358 support by setting correct flags
authorRafał Miłecki <rafal@milecki.pl>
Wed, 8 Feb 2023 09:16:37 +0000 (10:16 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 10 Feb 2023 06:25:31 +0000 (22:25 -0800)
commitd61615c366a489646a1bfe5b33455f916762d5f4
tree6e0b1459f2a095bf272d7c84b283497d005c6697
parent35674e787518768626d3a0ffce1c13a7eeed922d
net: bgmac: fix BCM5358 support by setting correct flags

Code blocks handling BCMA_CHIP_ID_BCM5357 and BCMA_CHIP_ID_BCM53572 were
incorrectly unified. Chip package values are not unique and cannot be
checked independently. They are meaningful only in a context of a given
chip.

Packages BCM5358 and BCM47188 share the same value but then belong to
different chips. Code unification resulted in treating BCM5358 as
BCM47188 and broke its initialization.

Link: https://github.com/openwrt/openwrt/issues/8278
Fixes: cb1b0f90acfe ("net: ethernet: bgmac: unify code of the same family")
Cc: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20230208091637.16291-1-zajec5@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bgmac-bcma.c