OSDN Git Service

checkkconfigsymbols.py: Forbid passing 'HEAD' to --commit
authorAriel Marcovitch <arielmarcovitch@gmail.com>
Wed, 1 Sep 2021 14:52:12 +0000 (17:52 +0300)
committerMasahiro Yamada <masahiroy@kernel.org>
Sun, 19 Sep 2021 01:13:03 +0000 (10:13 +0900)
commitd62d5aed3354ae57d57fae1e59948913f360d4eb
tree22ebf163123a5998f26552be628350dbfc062cfb
parent6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f
checkkconfigsymbols.py: Forbid passing 'HEAD' to --commit

As opposed to the --diff option, --commit can get ref names instead of
commit hashes.

When using the --commit option, the script resets the working directory
to the commit before the given ref, by adding '~' to the end of the ref.

However, the 'HEAD' ref is relative, and so when the working directory
is reset to 'HEAD~', 'HEAD' points to what was 'HEAD~'. Then when the
script resets to 'HEAD' it actually stays in the same commit. In this
case, the script won't report any cases because there is no diff between
the cases of the two refs.

Prevent the user from using HEAD refs.

A better solution might be to resolve the refs before doing the
reset, but for now just disallow such refs.

Signed-off-by: Ariel Marcovitch <arielmarcovitch@gmail.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/checkkconfigsymbols.py